Skip to content

🐛 Fix task status percentage #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

🐛 Fix task status percentage #7422

merged 2 commits into from
Mar 25, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 25, 2025 •
edited
Loading

What do these changes do?

  • Fix task status percentage in long running tasks (async jobs).

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Mar 25, 2025
@bisgaard-itis bisgaard-itis added the bug buggy, it does not work as expected label Mar 25, 2025
@bisgaard-itis bisgaard-itis added this to the The Awakening milestone Mar 25, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review March 25, 2025 12:23
sanderegg
sanderegg approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will force-push it

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 4d91e4a into ITISFoundation:master Mar 25, 2025
43 checks passed
pcrespov
pcrespov approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

THOUGHT: do you have a test that ensures that if someone changes it back (by mistake) to .actual_value it shows that is wrong? i

@codecov
Copy link

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (b453ddc) to head (11b9418).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7422      +/-   ##
==========================================
- Coverage   87.31%   84.01%   -3.31%     
==========================================
  Files        1714      663    -1051     
  Lines       66594    31722   -34872     
  Branches     1131      168     -963     
==========================================
- Hits        58147    26650   -31497     
+ Misses       8125     5014    -3111     
+ Partials      322       58     -264
Flag Coverage Δ
integrationtests 65.14% <ø> (-0.03%) ⬇️
unittests 87.12% <ø> (+0.64%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.74%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.68% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b453ddc...11b9418. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis deleted the fix-task-status-percentage branch March 25, 2025 12:55
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@bisgaard-itis @mrnicegyu11
🐛 Fix task status percentage (ITISFoundation#7422)
fac3590
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

bug buggy, it does not work as expected

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@bisgaard-itis @GitHK @pcrespov @sanderegg